Fix resource registry handle in V2 Forker handles #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires IntersectMBO/io-classes-extra#9 |
jasagredo
force-pushed
the
js/fix-resource-registry
branch
3 times, most recently
from
3fca3f5 to
ac1b251
Compare
jasagredo
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
ac1b251 to
7b4251e
Compare
|
Requires an update to |
|
The new packages that were brought by the Hackage update: -ImpSpec-0.1.0.0 lib
+ImpSpec-0.2.0.0 lib
-brick-2.9 lib
+brick-2.10 lib
-dependent-map-0.4.0.0 lib
+dependent-map-0.4.0.1 lib
-fs-sim-0.4.0.0 lib
+fs-sim-0.4.1.0 lib
-generic-lens-2.2.2.0 lib
+generic-lens-2.3.0.0 lib
-generic-lens-core-2.2.1.0 lib
+generic-lens-core-2.3.0.0 lib
-generic-optics-2.2.1.0 lib
+generic-optics-2.3.0.0 lib
-hedgehog-1.5 lib
+hedgehog-1.7 lib
-hspec-2.11.13 lib
+hspec-2.11.14 lib
-hspec-core-2.11.13 lib
+hspec-core-2.11.14 lib
-hspec-discover-2.11.13 lib
+hspec-discover-2.11.14 lib
-hspec-discover-2.11.13 exe:hspec-discover
+hspec-discover-2.11.14 exe:hspec-discover
-lifted-async-0.10.2.7 lib
+lifted-async-0.11.0 lib
-microlens-0.4.13.1 lib
+microlens-0.4.14.0 lib
-microlens-ghc-0.4.14.3 lib
+microlens-ghc-0.4.15.1 lib
-parallel-3.2.2.0 lib
+parallel-3.3.0.0 lib
-pretty-simple-4.1.3.0 lib
+pretty-simple-4.1.4.0 lib
-pretty-simple-4.1.3.0 exe:pretty-simple
+pretty-simple-4.1.4.0 exe:pretty-simple
-regex-tdfa-1.3.2.4 lib
+regex-tdfa-1.3.2.5 lib
-resource-registry-0.1.1.0 lib
+resource-registry-0.2.0.0 lib
-statistics-0.16.3.0 lib
+statistics-0.16.4.0 lib
-unordered-containers-0.2.20 lib
+unordered-containers-0.2.20.1 lib |
jasagredo
force-pushed
the
js/fix-resource-registry
branch
2 times, most recently
from
45d90f6 to
25b3689
Compare
jasagredo
force-pushed
the
js/update-constraints
branch
from
caff101 to
231b05e
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
25b3689 to
c578556
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
2 times, most recently
from
c6513dd to
e56aeb5
Compare
amesgen
reviewed
Oct 28, 2025
There was a problem hiding this comment.
Maybe 9384806 should be spinned off from this PR as it actually is an independent problem on main? Or at least, the commit message could be updated to indicate that this is not just about avoiding some unnecessary work, but rather important to avoid leaking forkers and hence causing deadlocks in (at least) V1?
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
e56aeb5 to
8a10d3f
Compare
jasagredo
changed the base branch from
main
to
js/fix-mempool-dangling-forker-forward-port
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
8a10d3f to
dc903ef
Compare
Base automatically changed from
js/fix-mempool-dangling-forker-forward-port
to
js/bangs
October 29, 2025 12:15
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
dc903ef to
63c4347
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
A partial backport of #1714. The forker was being opened always, and in the following situation it will be leaked and block the V1 LedgerDB lock forever: - 2 blocks - which are adopted in (increasing select view order) sequence (possibly by them being part of a slot battle and getting the losing one first) - very fast so that the mempool tries to revalidate exactly in between the blocks - it opens and holds forever a forker, it loses all reference to the forker (leaked resource) - then a flush happens and blocks forever as the (reading) forker in the previous step is open forever, and flushing requests a write lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patch
resource-registry ^>= 0.2.Non-Breaking
Do not open forkers unnecessarily in the Mempool when re-syncing it.
Committing a forker will move the handles to the registry of the LedgerDB. The
discarded fork will be queued to be released by the
garbageCollectlogic.